-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: remove openlibm #56875
base: master
Are you sure you want to change the base?
build: remove openlibm #56875
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
I had a crazy idea: since libc on windows (msvcrt) is missing some functions, let's wrap and use those functions from C++ (libstdc++). |
# For test only | ||
# https://github.com/JuliaLang/julia/pull/56875 | ||
# Only build on windows | ||
ifneq ($(OS), WINNT) | ||
# not on win32 | ||
$(error "JuliaLang/julia#56875" Only build on windows) | ||
endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not merge this pr.
With newer msvcrt from gcc14, we can build julia-x64 without openblibm |
5a78588
to
fde32eb
Compare
Now, we passed all tests on x86 and x64 https://buildkite.com/julialang/julia-master/builds/43191#0193e8a8-9d95-47cb-95e9-403619dd44ed |
Does this mean that on Windows we'd need to require a very recent compiler? |
MSYS2 only keeps the latest version of the package, so GCC 14 is used here. Maybe a newer version of gcc isn't necessary, but I haven't tested it yet. |
See if we've got some progress for #42299
After using gcc14 and updating the CSL,
I was able to build successfully locally and pass most of the stable tests.
Let's see if we can build successfully on the mainline and pass the tests.