Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix handling of unknown setting in @constprop, fix error message #56946

Merged
merged 6 commits into from
Jan 6, 2025
Merged

fix handling of unknown setting in @constprop, fix error message #56946

merged 6 commits into from
Jan 6, 2025

Conversation

nsajko
Copy link
Contributor

@nsajko nsajko commented Jan 4, 2025

No description provided.

@nsajko nsajko added error handling Handling of exceptions by Julia or the user bugfix This change fixes an existing bug error messages Better, more actionable error messages macros @macros backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 labels Jan 4, 2025
@nsajko
Copy link
Contributor Author

nsajko commented Jan 4, 2025

The current behavior is for @constprop :unknown f() = 3 to fail with a MethodError because of a typo when trying to construct the ArgumentError.

nsajko
nsajko commented Jan 4, 2025
View reviewed changes
base/expr.jl Outdated Show resolved Hide resolved
aviatesk
aviatesk reviewed Jan 5, 2025
View reviewed changes
base/expr.jl Outdated Show resolved Hide resolved
nsajko
nsajko commented Jan 5, 2025
View reviewed changes
base/expr.jl Outdated Show resolved Hide resolved
@nsajko nsajko force-pushed the fix_constprop_error_handling branch from 2ab15ed to 30818e6 Compare January 5, 2025 11:15
@aviatesk aviatesk merged commit a3f336f into JuliaLang:master Jan 6, 2025
5 of 7 checks passed
@nsajko nsajko deleted the fix_constprop_error_handling branch January 6, 2025 09:27
This was referenced Jan 28, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jishnub jishnub jishnub left review comments

@aviatesk aviatesk aviatesk approved these changes

Assignees
No one assigned
Labels
backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to release-1.11 bugfix This change fixes an existing bug error handling Handling of exceptions by Julia or the user error messages Better, more actionable error messages macros @macros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nsajko @jishnub @aviatesk