Support adding CodeInstances to JIT for interpreters defining a codegen cache
#57272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serenity4
changed the title
CodeInstances to JIT for interpreters defining a codegen cache
serenity4
changed the title
CodeInstances to JIT for interpreters defining a codegen cacheCodeInstances to JIT for interpreters defining a codegen cache
|
I also believe that, instead of exposing |
|
I'm a bit concerned about this, specifically because up to now everything that went into the JIT via the usual codepaths used the jl_create_native + JLJITAddLLVMIRModule. But this is not necessarily wrong, also @vchuravy probably has some comments on this |
|
This seems reasonable to me, based on the direction Keno has been going with |
|
Seems like |
serenity4
force-pushed
the
add-codeinst-to-jit
branch
from
151616f to
8644cb2
Compare
|
Crash was due to a reassignment of the local |
KristofferC
pushed a commit
that referenced
this pull request
Mar 31, 2025
…egen cache (#57272) Implements a way to add `CodeInstance`s compiled by external interpreters to JIT, such that they become legal targets for `invoke` calls. Based on a design proposed by @Keno, the `AbstractInterpreter` interface is extended to support providing a codegen cache that is filled during inference for future use with `add_codeinsts_to_jit!`. This allows `invoke(f, ::CodeInstance, args...)` to work on external interpreters, which is currently failing on `master` (see #57193). --------- Co-authored-by: Cédric Belmant <cedric.belmant@juliahub.com> (cherry picked from commit 9d2e9ed)
KristofferC
pushed a commit
that referenced
this pull request
Mar 31, 2025
…egen cache (#57272) Implements a way to add `CodeInstance`s compiled by external interpreters to JIT, such that they become legal targets for `invoke` calls. Based on a design proposed by @Keno, the `AbstractInterpreter` interface is extended to support providing a codegen cache that is filled during inference for future use with `add_codeinsts_to_jit!`. This allows `invoke(f, ::CodeInstance, args...)` to work on external interpreters, which is currently failing on `master` (see #57193). --------- Co-authored-by: Cédric Belmant <cedric.belmant@juliahub.com> (cherry picked from commit 9d2e9ed)
serenity4
added a commit
to serenity4/julia
that referenced
this pull request
May 1, 2025
…egen cache (JuliaLang#57272) Implements a way to add `CodeInstance`s compiled by external interpreters to JIT, such that they become legal targets for `invoke` calls. Based on a design proposed by @Keno, the `AbstractInterpreter` interface is extended to support providing a codegen cache that is filled during inference for future use with `add_codeinsts_to_jit!`. This allows `invoke(f, ::CodeInstance, args...)` to work on external interpreters, which is currently failing on `master` (see JuliaLang#57193). --------- Co-authored-by: Cédric Belmant <cedric.belmant@juliahub.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a way to add
CodeInstances compiled by external interpreters to JIT, such that they become legal targets forinvokecalls.Based on a design proposed by @Keno, the
AbstractInterpreterinterface is extended to support providing a codegen cache that is filled during inference for future use withadd_codeinsts_to_jit!.This allows
invoke(f, ::CodeInstance, args...)to work on external interpreters, which is currently failing onmaster(see #57193).