Change balancing options for eigen functions. #5731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eigenfunctions... ha ha. You're absolutely right, I generally dislike passing kwargs in their entirety. In this case however, I do see the 'necessary evil' use case. I'll leave this to your discretion. |
andreasnoack
added a commit
that referenced
this pull request
Feb 11, 2014
Change balancing options for eigen functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #5428 and JuliaLang/LinearAlgebra.jl#72. @jiahao I have used the
kwargs...trick that you don't like. If I write the keywords out then all eigen functions must have those arguments even though they don't support balancing for good reasons.