Skip to content

Conversation

Zentrik
Copy link
Member

@Zentrik Zentrik commented Feb 10, 2025

For LLVM 20, we still need to deal with #55844, #57021 and get the LLVM 19 PR in.

@nsajko nsajko added upstream The issue is with an upstream dependency, e.g. LLVM external dependencies Involves LLVM, OpenBLAS, or other linked libraries compiler:llvm For issues that relate to LLVM labels Feb 10, 2025
@giordano
Copy link
Member

Is this PR good to go for the time being? Further improvements could be done in follow up PRs.

@Zentrik
Copy link
Member Author

Zentrik commented Feb 18, 2025

Is this PR good to go for the time being? Further improvements could be done in follow up PRs.

Yes

@vtjnash
Copy link
Member

vtjnash commented Feb 18, 2025

Does this include any of the fixes in #56130? My initial impression is that those are missing here

@Zentrik
Copy link
Member Author

Zentrik commented Feb 18, 2025

Does this include any of the fixes in #56130? My initial impression is that those are missing here

No I don't think this includes any of them, do we want it to?

@vchuravy
Copy link
Member

No I don't think this includes any of them, do we want it to?

Yeah, generally my strategy was always to merge the fixes ahead of time in seperate PRs, and then only have the "flip the switch" PR without any code changes.

@Zentrik
Copy link
Member Author

Zentrik commented Feb 25, 2025

Yeah, generally my strategy was always to merge the fixes ahead of time in seperate PRs, and then only have the "flip the switch" PR without any code changes.

Is this in reference to adding llvm 19 or 20 support? This is what I intended for 19, but a bunch of issues only became apparent once we flipped the switch and I didn't think it was worth it to try and split those changes out.

Anyways, the 19 pr should be merged in soon so moot point anyways.

@giordano giordano merged commit c8cd8fd into JuliaLang:master Feb 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:llvm For issues that relate to LLVM external dependencies Involves LLVM, OpenBLAS, or other linked libraries upstream The issue is with an upstream dependency, e.g. LLVM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants