Base.summarysize for Memory with Union
#57508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is only one possible fix. The alternative would be to not account for the union byte array in It might be that there is a more consistent way to define |
giordano
changed the title
Base.summarysize for Memory with UnionBase.summarysize for Memory with Union
LilithHafner
approved these changes
Feb 23, 2025
Member
LilithHafner
left a comment
LilithHafner
left a comment
There was a problem hiding this comment.
Thanks for contributing, @PatrickHaecker! This looks great to me. I'm going to wait a bit before merging to see of @oscardssmith wants to chime in.
oscardssmith
approved these changes
Feb 23, 2025
Member
|
thanks for this! |
nsajko
added
backport 1.11
KristofferC
pushed a commit
that referenced
this pull request
Feb 26, 2025
KristofferC
pushed a commit
that referenced
this pull request
Mar 11, 2025
KristofferC
removed
the
backport 1.12
KristofferC
pushed a commit
that referenced
this pull request
Mar 25, 2025
KristofferC
removed
the
backport 1.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the double accounting of the union byte array in
Base.summarysizeas described in #57506.If this is the correct fix, can it be backported to 1.11?
Fix #57506