[Compiler] fix some cycle_fix_limited usage #57545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recompute some O(n) things a bit less on every statement. Fix an assert that ensured LimitedAccuracy does not accidentally get preserved when it should have been deleted: the (local) cache should not contain things that are marked as dead (RIP), as that was leading to much code not getting cached when it logically should have. Simplify the computation of frame_parent when the cycle_parent isn't needed.
vtjnash
added
compiler:inference
vtjnash
commented
Feb 26, 2025
| nargtypes = length(given_argtypes) | ||
| for cached_result in cache | ||
| cached_result.linfo === mi || @goto next_cache | ||
| cached_result.tombstone && continue # ignore deleted entries (due to LimitedAccuracy) |
There was a problem hiding this comment.
FWIW: this is the bugfix, the rest is various improvements of various sorts
n.b. the LimitedAccuracy object does not need to contain a Set anymore, since all of the nodes now have a frameid::Int, which is reliable and strongly ordered, so we could now build the lattice over the frameid value instead, which may be much simpler.
serenity4
added a commit
to serenity4/Cthulhu.jl
that referenced
this pull request
Feb 28, 2025
serenity4
added a commit
to serenity4/Cthulhu.jl
that referenced
this pull request
Feb 28, 2025
KristofferC
pushed a commit
that referenced
this pull request
Mar 3, 2025
Recompute some O(n) things a bit less on every statement. Fix an assert that ensured LimitedAccuracy does not accidentally get preserved when it should have been deleted: the (local) cache should not contain things that are marked as dead (RIP), as that was leading to much code not getting cached when it logically should have. Simplify the computation of frame_parent when the cycle_parent isn't needed. (cherry picked from commit 0366a2a)
aviatesk
pushed a commit
to JuliaDebug/Cthulhu.jl
that referenced
this pull request
Mar 3, 2025
* Adapt to JuliaLang/julia#57545 * Adapt to JuliaLang/julia#57545 * Fixes * Bump version * Add tighter version checks * Revert accidental edit * Simplify version checks --------- Co-authored-by: Cédric Belmant <cedric.belmant@juliahub.com>
nsajko
reviewed
Mar 4, 2025
| frames = sv.callstack::Vector{AbsIntState} | ||
| causes = typ.causes | ||
| for frameid = cycleid:length(frames) | ||
| caller = frames[frameid]::InferenceState |
KristofferC
removed
the
backport 1.12
serenity4
pushed a commit
to serenity4/julia
that referenced
this pull request
May 1, 2025
Recompute some O(n) things a bit less on every statement. Fix an assert that ensured LimitedAccuracy does not accidentally get preserved when it should have been deleted: the (local) cache should not contain things that are marked as dead (RIP), as that was leading to much code not getting cached when it logically should have. Simplify the computation of frame_parent when the cycle_parent isn't needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recompute some O(n) things a bit less on every statement. Fix an assert that ensured LimitedAccuracy does not accidentally get preserved when it should have been deleted: the (local) cache should not contain things that are marked as dead (RIP), as that was leading to much code not getting cached when it logically should have. Simplify the computation of frame_parent when the cycle_parent isn't needed.