lowering: Allow chaining of >: in where
#57554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlechu
added
the
compiler:lowering
JeffBezanson
approved these changes
Feb 27, 2025
Member
|
Thanks @mlechu ! |
KristofferC
pushed a commit
that referenced
this pull request
Mar 3, 2025
This change removes an inconsistency between `>:` and `<:`. We were
parsing `where {A>:B>:C}` forms, but not recognizing them in lowering.
Before:
```
julia> Vector{T} where Int<:T<:Number
Vector{T} where Int64<:T<:Number
julia> Vector{T} where Number>:T>:Int
ERROR: syntax: invalid bounds in "where" around REPL[14]:1
```
After:
```
julia> Vector{T} where Number>:T>:Int
Vector{T} where Int64<:T<:Number
```
(cherry picked from commit 2e57730)
KristofferC
removed
the
backport 1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes an inconsistency between
>:and<:. We were parsingwhere {A>:B>:C}forms, but not recognizing them in lowering.Before:
After: