Compiler: abstract calls: type assert to help stability #57582
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems `la` is getting inferred as `Integer` instead of as `Int` for some reason. This reduces the number of invalidations from 2061 to 2046 on running this code: ```julia struct I <: Integer end Base.Int64(::I) = 7 ```
|
This reminds me of PR #55583 😄 Another thing I tried, apart from just type asserting, is replacing the line fargs = arginfo.fargs
argtypes = arginfo.argtypesHowever that didn't help. |
|
Huh, this is strange. It's just a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems
lais getting inferred asIntegerinstead of asIntfor some reason.This reduces the number of invalidations from 2061 to 2046 on running this code: