-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
improve sysimage.mk more completely #57758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cf56062
to
d918023
Compare
Add back support for -debug builds and define ability to use shared library builds more places.
d918023
to
bb34b67
Compare
Compiled files load much faster, in the end, generally saving the extra time needed to generate them. This appears to make the last stage in the build about a minute faster.
bb34b67
to
6b67970
Compare
This seems to have impacted pre-compilation statements in the build. With PR: Collecting and executing precompile statements
└ Collect (Basic: ✓ 261) => Execute ✓ 340
Precompilation complete. Summary:
Total ─────── 4.582742 seconds Without PR: Collecting and executing precompile statements
└ Collect (Basic: ✓ 1189) => Execute ✓ 1258
Precompilation complete. Summary:
Total ─────── 38.161908 seconds |
Good, that was the goal |
We appear to have saved over 30 seconds there doing useless work |
Oh, that's great! I wasn't expecting "used shared libraries" to affect what we're pre-compiling. What's the bit that helps? |
I think this now requires a full basecompiler build with debug just in order to get a debug build of julia. It used to be that it could just generate the .so from the existing sysimage. I think that's a significant usability regression because that takes many, many minutes. |
It still could, even though this currently makes the choice towards being more reliable (since the previous design could be convinced--with a good bit of effort--to crash if used with
That is mostly an implementation regression from the bindings changes though (bootstrapping relies very heavily on some features that are currently broken due to the bindings changings), which should be improved upon soon |
Add back support for -debug builds and define ability to use shared
library builds more places in the file.
Fix #57675