better abstract type inference for oftype
#57951
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsajko
added
backport 1.10
|
(new test fails) |
|
Oof, sorry, I made a typo while trying this out in the REPL ( The test can be made to pass by applying the typeassert to the final return value, instead of to just one side of the branch, so that's what I'll do instead. |
nsajko
changed the title
oftype for better type inferenceoftype
Achieve better abstract return type inference by moving the typeassert to after the branch, so it affects both sides of the branch. Also deduplicate `typeof(x)` calls.
nsajko
changed the title
oftypeoftype
nsajko
force-pushed
the
better_inference_for_oftype_via_common_subexpression_elimination
branch
from
f5083c4 to
0c0dfc4
Compare
nsajko
removed
backport 1.10
|
The PR doesn't just deduplicate code any more, so gonna refrain from requesting backports. Sorry for the noise. |
nsajko
deleted the
better_inference_for_oftype_via_common_subexpression_elimination
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Achieve better abstract return type inference by moving the typeassert to after the branch, so it affects both sides of the branch. Also deduplicate
typeof(x)calls.