Skip to content

Conversation

@serenity4
Copy link
Member

Continues work on #56655, rebased onto current master.

@serenity4 serenity4 changed the base branch from kc/parallel_compiler to master April 2, 2025 14:34
@KristofferC
Copy link
Member

Would also have been ok to just push to #56655 instead of creating a new PR and losing the comments etc. Anyway, I'll just close the old one.

@Keno
Copy link
Member

Keno commented Apr 2, 2025

Would also have been ok to just push to #56655 instead of creating a new PR and losing the comments etc. Anyway, I'll just close the old one.

@serenity4 doesn't have commit bit right now, so I told him to just go ahead and do a new one.

@KristofferC
Copy link
Member

KristofferC commented Apr 2, 2025

Makes sense, out of curiosity, what was wrong with #56655. CI seemed to pass and the comments were addressed AFAIU. If further things were needed I could just have fixed those as well..?

@Keno
Copy link
Member

Keno commented Apr 2, 2025

AFAICT we just lost track of it. I was trying to find it yesterday, but couldn't, so I asked @serenity4 to look into finishing it. I didn't remember what the status of it was. New PR is just for rebase purposes.

@KristofferC
Copy link
Member

Ok, also possible to just rebase from the UI. 🤷 oh well.

@serenity4
Copy link
Member Author

serenity4 commented Apr 2, 2025

Besides rebasing and re-running CI, the intention was to be able to push changes if needed. But if all the work is actually done and tests pass so that nothing needs to be updated, that new PR would have been unnecessary indeed 😅 let's see.

@serenity4
Copy link
Member Author

The test revise failure is unrelated (was observed in another PR: https://buildkite.com/julialang/julia-master/builds/46459#0195fa09-0417-4ca9-bc9c-b97173dc7cc7), I'm looking into the profiling failure.

@KristofferC
Copy link
Member

KristofferC commented Apr 3, 2025

That profiling test is known to be flaky.

@serenity4
Copy link
Member Author

I guess we can merge these changes then. Given that I haven't contributed anything useful here, feel free to close this PR and reopen/merge #56655.

@serenity4 serenity4 marked this pull request as ready for review April 3, 2025 20:01
@KristofferC
Copy link
Member

Commits are the same so it doesn't really matter what PR they come from :)

@KristofferC KristofferC requested a review from Keno April 3, 2025 20:49
@KristofferC KristofferC merged commit 9d00b57 into JuliaLang:master Apr 7, 2025
4 of 7 checks passed
@serenity4 serenity4 deleted the kc/parallel_compiler branch April 7, 2025 14:48
serenity4 added a commit to serenity4/julia that referenced this pull request May 1, 2025
…7987)

Co-authored-by: KristofferC <kristoffer.carlsson@juliacomputing.com>
Co-authored-by: Cédric Belmant <cedric.belmant@juliahub.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants