-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Run Compiler tests in parallel for Pkg.test, continued
#57987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Would also have been ok to just push to #56655 instead of creating a new PR and losing the comments etc. Anyway, I'll just close the old one. |
@serenity4 doesn't have commit bit right now, so I told him to just go ahead and do a new one. |
|
Makes sense, out of curiosity, what was wrong with #56655. CI seemed to pass and the comments were addressed AFAIU. If further things were needed I could just have fixed those as well..? |
|
AFAICT we just lost track of it. I was trying to find it yesterday, but couldn't, so I asked @serenity4 to look into finishing it. I didn't remember what the status of it was. New PR is just for rebase purposes. |
|
Ok, also possible to just rebase from the UI. 🤷 oh well. |
|
Besides rebasing and re-running CI, the intention was to be able to push changes if needed. But if all the work is actually done and tests pass so that nothing needs to be updated, that new PR would have been unnecessary indeed 😅 let's see. |
|
The |
|
That profiling test is known to be flaky. |
|
I guess we can merge these changes then. Given that I haven't contributed anything useful here, feel free to close this PR and reopen/merge #56655. |
|
Commits are the same so it doesn't really matter what PR they come from :) |
…7987) Co-authored-by: KristofferC <kristoffer.carlsson@juliacomputing.com> Co-authored-by: Cédric Belmant <cedric.belmant@juliahub.com>
Continues work on #56655, rebased onto current
master.