[Compiler] Add more tests for non-power-of-two primitive types #58437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
added
test
|
This may break if and when C decides what BitInt is supposed to do alignment wise, but LGTM |
|
Sure, tests can always be consciously changed if necessary, the problem is when something breaks unnoticed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue reported in #42326 (inconsistent sizes for structs involving primitive types with non-power-of-two sizes) is already fixed since upgrading to LLVM 18, this PR adds regressions tests. I verified they already pass on x86_64, i686 and aarch64.
Close #42326.