Allow triple quoted strings as format strings for [@]printf
#5847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary hack for JuliaLang#2682, but the proper fix would be to fix the parser to not emit macroall to the AST for triple quoted strings. This commit also includes a ugly hack that will error when it is time to remove this fast fix. See: https://groups.google.com/forum/#!topic/julia-users/U1shoGwnCCQ
|
Closing this now. If there is interest, I might reopen and rebase so that it becomes mergeable again. |
|
Take this as a bump of #2682, to move the indentation removal code into the parser so that triple quoted strings can be parsed as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary hack for #2682, but the proper fix would be to fix the parser to not emit macroall to the AST for triple quoted strings.
This commit also includes a ugly hack that will error when it is time to remove this fast fix.
See: https://groups.google.com/forum/#!topic/julia-users/U1shoGwnCCQ