Skip to content

Add builtin function name to add methods error #59112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2025
+9 −6
Merged

Add builtin function name to add methods error #59112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f048adb
add builtin function name to error
IanButterworth Jul 28, 2025
32bcffa
rm "a"
IanButterworth Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/method.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1220,7 +1220,7 @@ JL_DLLEXPORT jl_method_t* jl_method_def(jl_svec_t *argdata,
// jl_value_t **ttypes = { jl_builtin_type, jl_tparam0(jl_anytuple_type) };
// jl_value_t *invalidt = jl_apply_tuple_type_v(ttypes, 2); // Tuple{Union{Builtin,OpaqueClosure}, Vararg}
// if (!jl_has_empty_intersection(argtype, invalidt))
// jl_error("cannot add methods to a builtin function");
// jl_error("cannot add methods to builtin function");
//}

assert(jl_is_linenode(functionloc));
Expand Down Expand Up @@ -1299,7 +1299,7 @@ JL_DLLEXPORT jl_method_t* jl_method_def(jl_svec_t *argdata,
}
ft = jl_rewrap_unionall(ft, argtype);
if (!external_mt && !jl_has_empty_intersection(ft, (jl_value_t*)jl_builtin_type)) // disallow adding methods to Any, Function, Builtin, and subtypes, or Unions of those
jl_error("cannot add methods to a builtin function");
jl_errorf("cannot add methods to builtin function `%s`", jl_symbol_name(name));

m = jl_new_method_uninit(module);
m->external_mt = (jl_value_t*)external_mt;
Expand Down
11 changes: 7 additions & 4 deletions test/core.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2661,13 +2661,16 @@ struct D14919 <: Function; end
@test B14919()() == "It's a brand new world"
@test C14919()() == D14919()() == "Boo."

let ex = ErrorException("cannot add methods to a builtin function")
let ex_t = ErrorException, ex_r = r"cannot add methods to builtin function"
for f in (:(Core.Any), :(Core.Function), :(Core.Builtin), :(Base.Callable), :(Union{Nothing,F} where F), :(typeof(Core.getfield)), :(Core.IntrinsicFunction))
@test_throws ex @eval (::$f)() = 1
@test_throws ex_t @eval (::$f)() = 1
@test_throws ex_r @eval (::$f)() = 1
end
@test_throws ex @eval (::Union{Nothing,F})() where {F<:Function} = 1
@test_throws ex_t @eval (::Union{Nothing,F})() where {F<:Function} = 1
@test_throws ex_r @eval (::Union{Nothing,F})() where {F<:Function} = 1
for f in (:(Core.getfield),)
@test_throws ex @eval $f() = 1
@test_throws ex_t @eval $f() = 1
@test_throws ex_r @eval $f() = 1
end
end

Expand Down