Skip to content

Add a long running warn to Base.runtests #59288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 21, 2025
Merged

Add a long running warn to Base.runtests #59288

merged 4 commits into from
Aug 21, 2025

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Aug 15, 2025 •
edited
Loading

  • Add a long-running message to Base.runtests. Otherwise when there's lots of output it can be tricky to figure out which worker is still running which test.
  • Also deemphasize the "started at" message as it confuses reading the table

Example with very short JULIA_TEST_LONGRUNNING_DELAY=1 JULIA_TEST_LONGRUNNING_INTERVAL=1
It's tunable so that it can be adjusted for e.g. the coverage CI which takes a lot longer.

Screenshot 2025-08-15 at 2 24 00 PM

@IanButterworth IanButterworth added the testsystem The unit testing framework and Test stdlib label Aug 15, 2025
IanButterworth added a commit to IanButterworth/julia-buildkite that referenced this pull request Aug 15, 2025
@IanButterworth
temporarily use JuliaLang/julia#59288
37efc80
ararslan
ararslan reviewed Aug 15, 2025
View reviewed changes
giordano
giordano reviewed Aug 15, 2025
View reviewed changes
IanButterworth and others added 4 commits August 15, 2025 23:12
@IanButterworth IanButterworth force-pushed the ib/runtests_longrunning branch from 6ef59ad to 70b487b Compare August 15, 2025 22:12
@IanButterworth IanButterworth merged commit 6a78395 into JuliaLang:master Aug 21, 2025
7 checks passed
@IanButterworth IanButterworth deleted the ib/runtests_longrunning branch August 21, 2025 07:26
IanButterworth added a commit to IanButterworth/julia-buildkite that referenced this pull request Aug 23, 2025
@IanButterworth
Revert "temporarily use JuliaLang/julia#59288"
f4a9d5d 
This reverts commit 37efc80.
@KristofferC KristofferC added the backport 1.12 Change should be backported to release-1.12 label Sep 1, 2025
KristofferC pushed a commit that referenced this pull request Sep 1, 2025
@IanButterworth @KristofferC
Add a long running warn to Base.runtests (#59288)
43460a1 
(cherry picked from commit 6a78395)
KristofferC pushed a commit that referenced this pull request Sep 2, 2025
@IanButterworth @KristofferC
Add a long running warn to Base.runtests (#59288)
3a9511e 
(cherry picked from commit 6a78395)
@KristofferC KristofferC removed the backport 1.12 Change should be backported to release-1.12 label Sep 11, 2025
KristofferC pushed a commit that referenced this pull request Sep 15, 2025
@IanButterworth
Add a long running warn to Base.runtests (#59288)
9ede785 
(cherry picked from commit 6a78395)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano left review comments

@ararslan ararslan ararslan left review comments

Assignees
No one assigned
Labels
testsystem The unit testing framework and Test stdlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IanButterworth @giordano @ararslan @KristofferC