Skip to content

Add _assert_to_string indirection for Expr-evaluated @assert #59298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

Add _assert_to_string indirection for Expr-evaluated @assert #59298

merged 1 commit into from
Aug 18, 2025

Conversation

topolarity
Copy link
Member

@topolarity topolarity commented Aug 15, 2025 •
edited
Loading

Not sure why this wasn't using this before since the code is effectively identical, but this allows:

@assert false "$("Hello,") assertion!"

to be --trim-"compatible" (unfortunately by deleting the assertion message...)

@topolarity
Add _assert_to_string indirection for Expr-evaluated @assert
69e24f1 
Not sure why this wasn't using this before, but this is important for
```julia
@Assert false "$("Hello,") assertion!"
```
to be `--trim`-compatible.
@topolarity topolarity added trimming Issues with trimming functionality or PR's relevant to its performance/functionality backport 1.12 Change should be backported to release-1.12 labels Aug 15, 2025
@KristofferC KristofferC mentioned this pull request Aug 18, 2025
Merged
38 tasks
@topolarity topolarity merged commit 2d9ee0a into JuliaLang:master Aug 18, 2025
11 checks passed
topolarity added a commit that referenced this pull request Aug 18, 2025
@topolarity
Add _assert_to_string indirection for Expr-evaluated @assert (#…
a2b0e15 
…59298)

Not sure why this wasn't using this before since the code is effectively
identical, but this allows:
```julia
@Assert false "$("Hello,") assertion!"
```
to be `--trim`-"compatible" (unfortunately by deleting the assertion
message...)
@topolarity topolarity mentioned this pull request Aug 18, 2025
Open
@KristofferC KristofferC removed the backport 1.12 Change should be backported to release-1.12 label Aug 19, 2025
KristofferC pushed a commit that referenced this pull request Sep 5, 2025
@topolarity
Add _assert_to_string indirection for Expr-evaluated @assert (#…
a3b003b 
…59298)

Not sure why this wasn't using this before since the code is effectively
identical, but this allows:
```julia
@Assert false "$("Hello,") assertion!"
```
to be `--trim`-"compatible" (unfortunately by deleting the assertion
message...)
KristofferC pushed a commit that referenced this pull request Sep 15, 2025
@topolarity
Add _assert_to_string indirection for Expr-evaluated @assert (#…
6d2d579 
…59298)

Not sure why this wasn't using this before since the code is effectively
identical, but this allows:
```julia
@Assert false "$("Hello,") assertion!"
```
to be `--trim`-"compatible" (unfortunately by deleting the assertion
message...)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeffBezanson JeffBezanson JeffBezanson approved these changes

Assignees

No one assigned

Labels

trimming Issues with trimming functionality or PR's relevant to its performance/functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@topolarity @JeffBezanson @KristofferC