[backports-release-1.11] Backport #59259 ("Fix compile time regression for null ptr comparisons") to Julia 1.11.x
#59446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
changed the title
backports-release-1.11] Backport (#59259) ("Fix compile time regression for null ptr comparisons") to Julia 1.11.x
DilumAluthge
changed the title
backports-release-1.11] Backport (#59259) ("Fix compile time regression for null ptr comparisons") to Julia 1.11.xbackports-release-1.11] Backport #59259 ("Fix compile time regression for null ptr comparisons") to Julia 1.11.x
|
@simeonschaub Hmmm, this does not seem sufficient :(. I'm still seeing the segfaults in CI. Example CI log: |
|
@gbaraldi Any ideas why this fails for LLVM 16? Is it because of incomplete support for opaque pointers? |
DilumAluthge
force-pushed
the
release-1.11
branch
from
64d2674 to
b04078d
Compare
|
This will need to be combined with a re-land of #59445. |
gbaraldi
changed the base branch from
release-1.11
to
backports-release-1.11
…11.x---backports-release-1.11
gbaraldi
deleted the
dpa/backport-pr59259-to-1.11.x---backports-release-1.11
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #59259 to 1.11 (cherry picked from commit 920df7a).
For more details, see #59445 (comment).
Targets
backports-release-1.11(#59336).