avoid startup deadlock in scheduler #59583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an unintended yield point inside OncePerThread which could lead to not getting the state for that thread, and might lead to deadlock. Convert that into a spin-wait on the status variable. This is inefficient, but of course per-thread state is bad.
|
ah well, too bad we don't have any core dumps then |
|
How do we get one? |
|
Most test runners have it enabled in our buildkite config. Maybe not that one? |
KristofferC
pushed a commit
that referenced
this pull request
Sep 24, 2025
(cherry picked from commit 61fdcea)
24 tasks
KristofferC
pushed a commit
that referenced
this pull request
Sep 24, 2025
(cherry picked from commit 61fdcea)
KristofferC
removed
the
backport 1.12
xal-0
pushed a commit
to xal-0/julia
that referenced
this pull request
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an unintended yield point inside OncePerThread which could lead to not getting the state for that thread, and might lead to deadlock. Convert that into a spin-wait on the status variable. This is inefficient, but of course per-thread state is bad.
Fixes #59538