Skip to content

Fix buffer overflow in jloptions #60299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vchuravy merged 2 commits into from
Dec 2, 2025
Merged

Fix buffer overflow in jloptions #60299

vchuravy merged 2 commits into from
Dec 2, 2025

Conversation

@vchuravy
Copy link
Member

@vchuravy vchuravy commented Dec 2, 2025

We currently assume that we have two threadspools, but the code above the mallocchanges the jl_options.nthreadpools

before we had:

-            if (jl_options.nthreadpools == 2)
-                ntpp[1] = (int16_t)nthreadsi;
+            ntpp[1] = (int16_t)nthreadsi;

Fixes #60298

@vchuravy vchuravy added bugfix This change fixes an existing bug backport 1.12 Change should be backported to release-1.12 labels Dec 2, 2025
@gbaraldi gbaraldi added the merge me PR is reviewed. Merge when all tests are passing label Dec 2, 2025
topolarity
topolarity reviewed Dec 2, 2025
View reviewed changes
@IanButterworth IanButterworth removed the merge me PR is reviewed. Merge when all tests are passing label Dec 2, 2025
@vchuravy @topolarity
Apply suggestion from @topolarity
e38d8ab 
Co-authored-by: Cody Tapscott <84105208+topolarity@users.noreply.github.com>
IanButterworth
IanButterworth approved these changes Dec 2, 2025
View reviewed changes
Copy link
Member

@IanButterworth IanButterworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, apologies. How did this slip through CI for so long?

@IanButterworth IanButterworth added the merge me PR is reviewed. Merge when all tests are passing label Dec 2, 2025
@vchuravy vchuravy merged commit 841148d into master Dec 2, 2025
7 of 9 checks passed
@vchuravy vchuravy deleted the vc/fix_jloptions branch December 2, 2025 17:32
@topolarity
Copy link
Member

topolarity commented Dec 2, 2025

How did this slip through CI for so long?

I suspect malloc usually pads the allocation so that this is mostly benign (but sanitizers will catch it of course)

@giordano
Copy link
Member

giordano commented Dec 2, 2025

I'm assuming this should be backported to v1.13, in addition to v1.12

@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label Dec 3, 2025
KristofferC pushed a commit that referenced this pull request Dec 4, 2025
@vchuravy @topolarity
Fix buffer overflow in jloptions (#60299)
613d162 
Co-authored-by: Cody Tapscott <84105208+topolarity@users.noreply.github.com>
(cherry picked from commit 841148d)
KristofferC pushed a commit that referenced this pull request Dec 4, 2025
@vchuravy @topolarity
Fix buffer overflow in jloptions (#60299)
4a666fb 
Co-authored-by: Cody Tapscott <84105208+topolarity@users.noreply.github.com>
(cherry picked from commit 841148d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@topolarity topolarity topolarity left review comments

@IanButterworth IanButterworth IanButterworth approved these changes

Assignees

No one assigned

Labels

backport 1.12 Change should be backported to release-1.12 backport 1.13 bugfix This change fixes an existing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ASAN 1.12.1 heap-buffer-overflow in jl_parse_opts

6 participants

@vchuravy @topolarity @giordano @IanButterworth @gbaraldi