Added eltype(itr::EachLine) #6114
Conversation
Also reimplemented one argument readlines() with collect.
| @@ -226,6 +226,11 @@ function done(itr::EachLine, nada) | |||
| true | |||
| end | |||
| next(itr::EachLine, nada) = (readline(itr.stream), nothing) | |||
| eltype(itr::EachLine) = String | |||
There was a problem hiding this comment.
Doesn't readline always return a ByteString?
There was a problem hiding this comment.
I would think so, as ByteString == Union(UTF8String,ASCIIString). Is there a lot of benefit using a Union instead of an abstract as type of an array?
There was a problem hiding this comment.
I doubt it matters much in practice, but my instinct was to declare the narrowest correct type on general principles.
|
I forgot about the trailing function arguments to |
|
Another potential application of |
|
Wouldn't |
|
It would just be a hook to generate a special type of expression. If the argument is not to be evaluated, you pretty much need something like that. |
|
Similar to the julia side of the definition of the |
The type returned from
readlinesisArray{Any,1}, and theEachLineiterator does not specify an element type. This PR attempts to fix those two issues.There is still an issue with the way list comprehensions are used in
collectthat makes the inferred type fromreadlineswider than necessary (Union(Array{String,1},Array{Union(UTF8String,ASCIIString),N})).Not sure if that is an issue that should be reported elsewhere.