Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arguments specifying subsets of eigenvalues in eigfact(Symmetric/Hermitian) #6652

Merged
merged 1 commit into from
Apr 27, 2014

Conversation

andreasnoack
Copy link
Member

No description provided.

@ViralBShah
Copy link
Member

Is it possible to directly show the output from travis in the PR? Cc: @loladiro

andreasnoack added a commit that referenced this pull request Apr 27, 2014
Add arguments specifying subsets of eigenvalues in eigfact(Symmetric/Hermitian)
@andreasnoack andreasnoack merged commit c8c7aae into master Apr 27, 2014
@andreasnoack andreasnoack deleted the anj/subeig branch April 27, 2014 20:13
@Keno
Copy link
Member

Keno commented Apr 27, 2014

I'm not sure what you're asking.

@JeffBezanson
Copy link
Member

From the docs, it was not clear to me how to specify that I'm passing il, iu as opposed to vl, vu. This seems to be based on whether the arguments are integers, which strikes me as extremely bad. Integers are also perfectly good numbers.

@jiahao
Copy link
Member

jiahao commented Apr 27, 2014

This syntax also exists in the stein! wrappers for SymTridiagonal eigenproblems. In retrospect, perhaps a more Julian syntax would be to specify the interval [vl, vu) as two numeric arguments and the range il:iu as a UnitRange. (The latter is semantically an ordinal range, specifying the ilth through iuth sorted eigenvalues, while the former is a semiopen interval.)

@JeffBezanson
Copy link
Member

That would be an improvement. The way it is now is really confusing, and will break in odd ways if the type of one of the numbers is not what you expect.

@andreasnoack
Copy link
Member Author

Good idea. I'll change the Int method to a method for UnitRange and the Float64 method to a Number method.

@andreasnoack
Copy link
Member Author

Done in #6678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants