Export Reverse in Base.Order #6780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems sensible to me. Should we wait a bit of is this fine to just swap out? I kind of think it's fine to change what Reverse means – the old thing was so broken and this is so different it's hard to imagine anyone not noticing this change. |
JeffBezanson
added a commit
that referenced
this pull request
May 8, 2014
Export Reverse in Base.Order
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, Base.Order did not export Reverse since it clashed with the Reverse iterator. However, Reverse iterator has since been removed (see #4590), so there is no longer any conflict.