RFC: added performance tests for sparse getindex + a README file #7177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 8, 2014
|
Cc @staticfloat |
|
I ran the sparse performance tests for Julia 0.2.1, 0.3 before PR #7131 and after. Here the results: Interestingly, performance decreased in many tests from 0.2.1 to 0.3-pre-PR, even though the getindex methods did not change! (why?) PR#7131 increased performance in all but 3 tests compared to 0.3-pre-PR. They are all for small-ish matrices of 1000x1000. I'll have a look at those. |
|
#6112 is tracking the performance regressions. Best to continue the performance regression part of the discussion there. |
| - `sort` various sorting algorithms | ||
| - `spell` an implementation of a spell corrector | ||
| [http://norvig.com/spell-correct.html](http://norvig.com/spell-correct.html) | ||
| - `sparse` related to sparse matrices |
There was a problem hiding this comment.
I'd round out these descriptions a bit more. Something along the lines of:
micro: A set of micro-benchmarks commonly used to compare programming languages; these results are shown on http://julialang.org/blas,lapack: Performance tests for linear algebra tasks from low-level operations such as matrix multiplies to higher-level operations like eigenvalue problems.cat: Performance tests for concatenation of vectors and matrices.kernel: Performance tests used to track real-world code examples that previously ran slowly.shootout: Tracks the performance of tests taken from the Debian shootout performance tests.sort: Performance tests of sorting algorithmsspell: Performance tests of Peter Norvig's spelling correctorsparse: Performance tests of sparse matrix operations.
|
Thanks @staticfloat, README is updated. |
|
lgtm |
staticfloat
added a commit
that referenced
this pull request
Jun 9, 2014
RFC: added performance tests for sparse getindex + a README file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #7131 @ViralBShah suggested that I should add the
getindexperformance test toperf/. Here a tidied up version of https://gist.github.com/mauro3/7f01931b5f25d7b397af.Questions:
README.mdas I tried to figure out howperf/works. Maybe this could be useful? It will need a read.codespeed?