Improve Set printing #7206
Closed
Improve Set printing #7206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if length(S) > 10^7 | ||
| A = copy!(Array(T, 1000), 1, S, 1, 1000) | ||
| else | ||
| A = sort!(T[x for x in S]) |
There was a problem hiding this comment.
You probably want:
A = T[x for x in S]
method_exists(isless, (T, T)) && sort!(A)
|
See also showdict. It really feels like we should have a more general solution to pretty-printing collections. |
|
So does anything need doing here, or are you going scrap this and implement a general solution? |
|
Right now I don't see a clean way to implement a more general solution, unfortunately. |
|
This is at least better than what we have now, so I say we go for it now and work on a more general solution in #7959. |
jiahao
force-pushed
the
master
branch
3 times, most recently
from
6c7c7e3 to
1a4c02f
Compare
|
The more general cleanup is done, so a reduced subset of the Set is shown now. I don't think it's clear that we want to attempt to imply an arbitrary ordering on it (#7153). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution was actually proposed by @stevengj on #7153
I'm just submitting it to get the ball rolling, or rolled.