REPL: Moving left and right was skipping newlines #7253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue JuliaLang#7210 fixed movement across combining characters, such that moving left and right by one character would skip all zero-width characters, but this also inadvertently includes newlines. This made it impossible to navigate to the end of a line that ended with a newline with the left and right arrows alone. And movement across multiple newlines would skip across them all at once. This fixes that and adds simple regression tests.
Keno
added a commit
that referenced
this pull request
Jun 13, 2014
REPL: Moving left and right was skipping newlines
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #7210 fixed movement across combining characters, such that moving left
and right by one character would skip all zero-width characters, but this also
inadvertently includes newlines. This made it impossible to navigate to the end
of a line that ended with a newline with the left and right arrows alone. And movement across multiple newlines would skip across them all at once.
This fixes that and adds simple regression tests.
cc: @Keno