moji char predicates #8233
moji char predicates #8233
Conversation
| @@ -30,6 +30,11 @@ Library improvements | |||
|
|
|||
| * Efficient `mean` and `median` for ranges ([#8089]). | |||
|
|
|||
| * Character predicates such as `islower()`, `isspace()`, etc. use `utf8proc`\`libmojibake` | |||
There was a problem hiding this comment.
forward slash, not backslash, in English. Also, no backquotes around utf8proc/libmojibake since these aren't code per se.
|
You also need to update the documentation in |
|
Docs added. Not sure what's up with the timestamps on the latest commits; perhaps related to the fact that I had to move Julia over to a different computer this morning. |
|
Oh ... it's apparently just that helpdb hadn't been updated recently, since that file is generated. |
|
Looks good to me. @jiahao? |
| @@ -1483,32 +1483,39 @@ Strings | |||
| .. function:: isgraph(c::Union(Char,String)) -> Bool | |||
|
|
|||
| Tests whether a character is printable, and not a space, or whether this | |||
| is true for all elements of a string. | |||
| is true for all elements of a string. Any character that would cause a printer | |||
| to use ink should be classified with isgraphic(c)==true. | |||
There was a problem hiding this comment.
This should be isgraph(c)==true, not isgraphic.
There was a problem hiding this comment.
OTOH, I think isgraph should be isgraphical... more clear.
There was a problem hiding this comment.
We're using the standard libc names for everything else, though, right? Would be weird to have just one of them different.
There was a problem hiding this comment.
Oh, I didn't know that was a libc thing. It probably shouldn't change then.
|
Travis passed on Linux but failed on OS X. It looks like #7939, so I think this PR is ok. |
|
Passed Travis this time. |
|
I'm going to go ahead and merge. Thanks for all your efforts on this! |
|
Great. Thanks for your patience in walking me through the process. |
This is a rebased version of PR #8110, addressing issue #5939.
cc @stevengj @ivarne