Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type inference for tuples in static parameters #9016

Merged
merged 1 commit into from
Jan 31, 2015
Merged

Conversation

Keno
Copy link
Member

@Keno Keno commented Nov 15, 2014

Tuples in static parameters were previously not inferred at all
(not even in their own constructors). This came up in Cxx.jl which
has a lot of tuples in type parameters.

@JeffBezanson

@jakebolewski
Copy link
Member

I have not checked if PR fixes it, but similar behavior was observed when looking into #8504 (inference for tuple type parameters failing).

@timholy
Copy link
Member

timholy commented Nov 23, 2014

Just FYI this does not fix any of the issues in #8504 or fix the bootstrap hang when I try to make further progress on #9098. (I didn't expect it to, but it was worth a try.) Not saying this isn't valuable, just that it's different.

@Keno
Copy link
Member Author

Keno commented Dec 23, 2014

bump @JeffBezanson

@Keno
Copy link
Member Author

Keno commented Jan 21, 2015

Gonna merge this soon, if there's no objection.

Tuples in static parameters were previously not inferred at all
(not even in their own constructors). This came up in Cxx.jl which
has a lot of tuples in type parameters.
Keno added a commit that referenced this pull request Jan 31, 2015
Improve type inference for tuples in static parameters
@Keno Keno merged commit dca57be into master Jan 31, 2015
@tkelman tkelman deleted the kf/tupletypeinf branch April 19, 2015 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants