Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Win/*NIX discrepancy in the tempname test #9054

Merged
merged 1 commit into from Nov 18, 2014
Merged

Fix Win/*NIX discrepancy in the tempname test #9054

merged 1 commit into from Nov 18, 2014

Conversation

ghost
Copy link

@ghost ghost commented Nov 18, 2014

Fixes a test failure due to a discrepancy discussed in #9053.

@tkelman
Copy link
Contributor

tkelman commented Nov 18, 2014

Looks like this was the only failure on win32, if it passes tests on win64 I'll merge. #6028 should prevent this kind of problem in the future.

@ghost
Copy link
Author

ghost commented Nov 18, 2014

Looks like this was the only failure on win32.

Um... what...? It is the same call for both, right?

#6028 should prevent this kind of problem in the future.

Indeed, as someone without a Windows dev-box to test on, I am looking forward to it.

@ghost
Copy link
Author

ghost commented Nov 18, 2014

Um... what...? It is the same call for both, right?

My bad, read it wrong. Ignore me.

@tkelman
Copy link
Contributor

tkelman commented Nov 18, 2014

Yeah it should be the same api, but I run the tests separately because you never know. Stranger things have happened.

@ghost
Copy link
Author

ghost commented Nov 18, 2014

Yeah it should be the same api, but I run the tests separately because you never know. Stranger things have happened.

Read your original message as "was only a failure on win32", I guess that means it is time to go for dinner.

tkelman added a commit that referenced this pull request Nov 18, 2014
Fix Win/*NIX discrepancy in the `tempname` test
@tkelman tkelman merged commit 9e07edd into JuliaLang:master Nov 18, 2014
@ghost ghost deleted the nin/mktmp_wintest branch November 19, 2014 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant