Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix so latex completion do not interfere with path completion in strings on windows. #9137

Merged
merged 1 commit into from
Nov 25, 2014
Merged

Fix so latex completion do not interfere with path completion in strings on windows. #9137

merged 1 commit into from
Nov 25, 2014

Conversation

dhoegh
Copy link
Contributor

@dhoegh dhoegh commented Nov 24, 2014

See disscusion #8983.
Is this what you imagined @tkelman?
It can just not complete when there two is a backslash

\\alpha<tab> #do not work anymore

but I can't really imagine it would be a problem, else a keyword argument can fix it.

@tkelman
Copy link
Contributor

tkelman commented Nov 24, 2014

@dhoegh can you reproduce and/or fix the following error on this branch?

julia> cd("C:\UERROR: \x used with no following hex digits

@tkelman
Copy link
Contributor

tkelman commented Nov 24, 2014

Oh, apparently that's on master too so I should open a new issue, unless you know how to fix it already.

@dhoegh
Copy link
Contributor Author

dhoegh commented Nov 24, 2014

Does the error occur when julia> cd("C:\U<tab>?

@tkelman
Copy link
Contributor

tkelman commented Nov 24, 2014

precisely, sorry if that was unclear

@tkelman
Copy link
Contributor

tkelman commented Nov 25, 2014

I did a bisect, the problem was introduced by adca441, apparently my tests of that were not thorough enough

@tkelman tkelman mentioned this pull request Nov 25, 2014
Merged
@dhoegh dhoegh mentioned this pull request Nov 25, 2014
Merged
@tkelman
Copy link
Contributor

tkelman commented Nov 25, 2014

No rush, but a test here too would be awesome. Thanks again for being so responsive on these tweaks.

@dhoegh dhoegh force-pushed the latex_completion_string_fix branch from 1c0236e to 564308b Compare November 25, 2014 18:57
@dhoegh
Copy link
Contributor Author

dhoegh commented Nov 25, 2014

@tkelman I have added a test.

@tkelman
Copy link
Contributor

tkelman commented Nov 25, 2014

Perfect

tkelman added a commit that referenced this pull request Nov 25, 2014
@tkelman
Merge pull request #9137 from dhoegh/latex_completion_string_fix
3d10054 
Fix so latex completion do not interfere with path completion in strings on windows.
@tkelman tkelman merged commit 3d10054 into JuliaLang:master Nov 25, 2014
@tkelman
Copy link
Contributor

tkelman commented Nov 27, 2014

removing backport pending label from this in lieu of #9165

(thanks for squashing and preparing the backports @dhoegh)

JeffBezanson added a commit that referenced this pull request Nov 30, 2014
@JeffBezanson
Merge pull request #9165 from dhoegh/Backport_latex_completion_strings
64578a9 
Backport of #8989 and #9137 squashed.
ivarne added a commit that referenced this pull request Dec 1, 2014
@ivarne
Fix #9209
4f2681f 
Regression from #9137. The problem was that the Latex completion code
might access an invalid index in the unicode string, if the previous
character from a `\\` was a multibyte character.
@ivarne ivarne mentioned this pull request Dec 1, 2014
Merged
ivarne added a commit that referenced this pull request Dec 5, 2014
@ivarne
Fix #9209
9c14147 
Regression from #9137. The problem was that the Latex completion code
might access an invalid index in the unicode string, if the previous
character from a `\\` was a multibyte character.
ivarne added a commit that referenced this pull request Dec 7, 2014
@ivarne
Fix #9209
6033478 
Regression from #9137. The problem was that the Latex completion code
might access an invalid index in the unicode string, if the previous
character from a `\\` was a multibyte character.

ref: #9210
(cherry picked from commit 9c14147)
@dhoegh dhoegh deleted the latex_completion_string_fix branch January 13, 2015 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhoegh @tkelman