Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add :noinline to prevent inlining. Fixes #9212 #9291

Merged
merged 2 commits into from
Dec 10, 2014
Merged

Add :noinline to prevent inlining. Fixes #9212 #9291

merged 2 commits into from
Dec 10, 2014

Conversation

timholy
Copy link
Member

@timholy timholy commented Dec 10, 2014

No description provided.

@timholy
Copy link
Member Author

timholy commented Dec 10, 2014

Even with this, on the first execution one can, for certain functions, receive multiple warnings. This happens because there seems to be some form of automatic loop unrolling active when the number of iterations is known at compile time. Consequently, within a single function (and corresponding to a single source line), the pointer address of the caller may exhibit multiple values.

Still, it's much better than it used to be.

@vtjnash
Copy link
Member

vtjnash commented Dec 10, 2014

💯

@timholy
Copy link
Member Author

timholy commented Dec 10, 2014

Do you want a @noinline macro as well? I wasn't sure there were use cases outside of this one, so I just implemented the expression support.

@rfourquet
Copy link
Member

At one point, I issued a PR whose sole purpose was to wrap an @inlined function only so that it's not inlined, which was greatly improving performances on my machine, so I think that @noinline can be justified (and also at the call site).

@timholy
Copy link
Member Author

timholy commented Dec 10, 2014

OK, good enough for me---added.

Once this turns green, I'll merge.

timholy added a commit that referenced this pull request Dec 10, 2014
Add :noinline to prevent inlining. Fixes #9212
@timholy timholy merged commit ed25518 into master Dec 10, 2014
@timholy timholy deleted the teh/warnonce branch December 10, 2014 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants