julia-mode.el: Set a maximum lookback for finding enclosing parens/blocks #9308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes JuliaLang#9254 -- performance is just too bad on long files otherwise.
|
Excellent! Love the tests. I might fiddle with it and set the numbers a bit higher; you can hit those limits e.g. in big dict and array literals. |
JeffBezanson
added a commit
that referenced
this pull request
Dec 11, 2014
julia-mode.el: Set a maximum lookback for finding enclosing parens/blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9254.
After further thought, I didn't like my proposed solution of just considering the previous line for indenting. The current approach is much smarter and more desirable -- we try to work out how many enclosing blocks we're in.
I've compromised by setting a maximum lookback for finding enclosing parens (this was the most expensive part) and for finding enclosing blocks (this is cheaper, but still affects performance, so I've set a higher value).
I've also added a few unit tests for indentation.
Let me know what you think, I think this is a big improvement. Sorry it took so long.
cc @JeffBezanson