Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to SuiteSparse 4.4.1. #9357

Merged
merged 2 commits into from
Dec 23, 2014
Merged

Update to SuiteSparse 4.4.1. #9357

merged 2 commits into from
Dec 23, 2014

Conversation

ViralBShah
Copy link
Member

No description provided.

@ViralBShah ViralBShah added the sparse Sparse arrays label Dec 14, 2014
@tkelman
Copy link
Contributor

tkelman commented Dec 14, 2014

This is going to break on appveyor because of my hack from d8cf6fe (we're still waiting for the windows buildbots to make new nightlies @staticfloat) which was fallout from #9189 and #9204

I'll push a temporary fix to this branch.

revert this commit and d8cf6fe once new nightlies are ready
@ViralBShah
Copy link
Member Author

There is no hurry to merge this PR. It is ok to let the earlier suitesparse stuff settle down.

@tkelman
Copy link
Contributor

tkelman commented Dec 14, 2014

Good point. Just warning about what was going to be a build failure. Feel free to rebase away b2a589d into oblivion once it's not necessary any more.

@tkelman
Copy link
Contributor

tkelman commented Dec 23, 2014

And ironically it failed with a timeout that I'm pretty sure is unrelated. We've had new nightlies for a while so I can revert my hack on AppVeyor if needed, though rebuilding suitesparse_wrapper on AppVeyor is pretty cheap and gives us the flexibility to add/remove/change code there if we need to, so I'll leave it in for now.

tkelman added a commit that referenced this pull request Dec 23, 2014
@tkelman tkelman merged commit 55f37ac into master Dec 23, 2014
@ViralBShah
Copy link
Member Author

Seems reasonable.

@tkelman tkelman deleted the vs/suitesparse branch December 27, 2014 06:48
@tkelman
Copy link
Contributor

tkelman commented Jan 6, 2015

Alright, suitesparse link is being flaky on AppVeyor, I'll take this bit out now. Though @staticfloat we could also mirror it, I don't know if we're up-to-date on the latest version on the S3 mirror right now?

@staticfloat
Copy link
Member

@tkelman it's added now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sparse Sparse arrays
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants