Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --int-literals option #9597

Merged
merged 1 commit into from
Mar 26, 2015
Merged

Remove --int-literals option #9597

merged 1 commit into from
Mar 26, 2015

Conversation

ihnorton
Copy link
Member

@ihnorton ihnorton commented Jan 4, 2015

Did I miss anything? ref #9567

@tkelman
Copy link
Contributor

tkelman commented Jan 4, 2015

Is it mentioned on the man page or in the docs? getting-started and I think one or two other places mention (some of the) command-line args but have gotten out of date.

@ihnorton
Copy link
Member Author

ihnorton commented Jan 4, 2015

Was in the first section of manual - thanks.

@tkelman
Copy link
Contributor

tkelman commented Jan 4, 2015

also

julia/doc/man/julia.1

Lines 123 to 125 in 96d97ca

.TP
--int-literals={32|64}
Select integer literal size independent of platform

and malformed tree failure on travis, oh boy

}
else {
return (jl_value_t*)jl_box_int64(i64);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, deleted way too much here. All this code should remain, just with different platform ifdefs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops :)

@JeffBezanson
Copy link
Member

Also need to change the JLCompilerOpts struct in inference.jl.

jl_compileropts.int_literals!=64
#endif
) {
if (i64 > (int64_t)S32_MAX || i64 < (int64_t)S32_MIN)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should always be used on 32-bit.

@JeffBezanson
Copy link
Member

Also the option help text in repl.c.

{ "compile", required_argument, 0, 303 },
{ "depwarn", required_argument, 0, 304 },
{ "inline", required_argument, 0, 305 },
{ "dump-bitcode", required_argument, 0, 301 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no tabs!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what happened.. I rebased with --whitespace=fix and apparently
something was misconfigured. In any case, I will wait to rebase this until
after Jake's compileropts PR is merged.

On Mon, Jan 5, 2015 at 3:04 PM, Tony Kelman notifications@github.com
wrote:

In ui/repl.c
#9597 (diff):

@@ -92,11 +92,10 @@ void parse_opts(int argcp, char **argvp)
{ "track-allocation",required_argument, 0, 'm' },
{ "check-bounds", required_argument, 0, 300 },
{ "optimize", no_argument, 0, 'O' },

  •    { "int-literals",  required_argument, 0, 301 },
    
  •    { "dump-bitcode",  required_argument, 0, 302 },
    
  •    { "compile",       required_argument, 0, 303 },
    
  •    { "depwarn",       required_argument, 0, 304 },
    
  •    { "inline",        required_argument, 0, 305 },
    
  •   { "dump-bitcode",  required_argument, 0, 301 },
    

no tabs!


Reply to this email directly or view it on GitHub
https://github.com/JuliaLang/julia/pull/9597/files#r22485714.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref: #9482

@ihnorton
Copy link
Member Author

Rebased.

@ihnorton
Copy link
Member Author

If there are no objections I'll merge this later today.

ihnorton added a commit that referenced this pull request Mar 26, 2015
Remove --int-literals option
@ihnorton ihnorton merged commit 3709cb7 into JuliaLang:master Mar 26, 2015
@ihnorton ihnorton deleted the fix9567 branch March 26, 2015 04:07
@PallHaraldsson
Copy link
Contributor

I kind of liked having this - for testing - mostly just saw it was broken.. 32-bit VM should do.. and then Julia code should work for sure (as in physical).

And another thing: My switchable literal type idea was shot down. For integer (or possibly for other types, say, strings - but not Decimal Float-literals..), should switching on runtime be possible as an alternative?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants