Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9947 #9952

Merged
merged 1 commit into from
Jan 30, 2015
Merged

Fix #9947 #9952

merged 1 commit into from
Jan 30, 2015

Conversation

kmsquire
Copy link
Member

No description provided.

@kmsquire
Copy link
Member Author

Ref: #9947 (comment)

vtjnash added a commit that referenced this pull request Jan 30, 2015
@vtjnash
Merge pull request #9952 from JuliaLang/kms/fix9947
51d5412 
Fix #9947
@vtjnash vtjnash merged commit 51d5412 into master Jan 30, 2015
@kmsquire
Copy link
Member Author

kmsquire commented Feb 3, 2015

@JuliaBackports

@kmsquire kmsquire mentioned this pull request Feb 3, 2015
Merged
@kmsquire kmsquire added this to the 0.3.6 milestone Feb 3, 2015
@kmsquire kmsquire removed this from the 0.3.6 milestone Feb 3, 2015
@kmsquire kmsquire mentioned this pull request Feb 3, 2015
Closed
@tkelman
Copy link
Contributor

tkelman commented Feb 6, 2015

If I attempt to backport this to release-0.3, I do still get

exception on 2: ERROR: test error during f9947() == Uint128(1)
type cannot be constructed
 in f9947 at core.jl:1900

@tkelman
Copy link
Contributor

tkelman commented Feb 6, 2015

Sorry, I think it's just the call constructor syntax for Uint(2) that I have to tweak

JeffBezanson added a commit that referenced this pull request Feb 6, 2015
@JeffBezanson @tkelman
Fix #9947
6186035 
(cherry picked from commit 2d684a7)
ref PR #9952

Conflicts:
	test/core.jl

adjust Uint construction syntax for 0.3
@tkelman
Copy link
Contributor

tkelman commented Feb 6, 2015

that worked, backported in 6186035 (please double-check that it's testing the right behavior)

@tkelman tkelman deleted the kms/fix9947 branch February 6, 2015 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kmsquire @tkelman @vtjnash @JeffBezanson