[Windows] Allow exceptions through to the OS #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to properly generate minidumps during actual events, it is necessary to disable the call to `SetErrorMode()` during libuv initialization and to remove the job flag `JOB_OBJECT_LIMIT_DIE_ON_UNHANDLED_EXCEPTION`, both of which interfered in the normal handling of exceptions. Finally, it was determined prudent to include `CREATE_DEFAULT_ERROR_MODE` when spawning new processes, to ensure that whatever error handling mode was set in the current process is not inherited by subprocesses.
staticfloat
added a commit
to JuliaLang/julia
that referenced
this pull request
Nov 17, 2022
This commit provides two pieces; first, it enables building libuv with `SIGQUIT` support on Windows (useful for [0]), and second it enables coredumping when exceptions are hit, after our exception handler has finished printing out a backtrace. This is useful for using WER to create dump files when we segfault, etc... This commit requires libuv PRs [1] and [2] to properly function. [0] #45864 [1] JuliaLang/libuv#30 [2] JuliaLang/libuv#31
This was referenced Nov 17, 2022
vtjnash
approved these changes
Nov 17, 2022
Member
vtjnash
left a comment
vtjnash
left a comment
There was a problem hiding this comment.
Could you submit this to libuv against the master branch there?
Member
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to properly generate minidumps during actual events, it is necessary to disable the call to
SetErrorMode()during libuv initialization and to remove the job flagJOB_OBJECT_LIMIT_DIE_ON_UNHANDLED_EXCEPTION, both of which interfered in the normal handling of exceptions. Finally, it was determined prudent to includeCREATE_DEFAULT_ERROR_MODEwhen spawning new processes, to ensure that whatever error handling mode was set in the current process is not inherited by subprocesses.