Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump thollander/actions-comment-pull-request from 2.5.0 to 3.0.1 #2201

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 1, 2024

Bumps thollander/actions-comment-pull-request from 2.5.0 to 3.0.1.

Release notes

Sourced from thollander/actions-comment-pull-request's releases.

v3.0.1

What's Changed

Full Changelog: thollander/actions-comment-pull-request@v3.0.0...v3.0.1

v3.0.0

What's Changed

Breaking changes

Parameters

  • From filePath to file-path
  • From GITHUB_TOKEN to github-token
  • From pr_number to pr-number
  • From comment_tag to comment-tag
  • From create_if_not_exists to create-if-not-exists

Mode

delete now deletes a comment immediately. To delete the comment at the end of the job, use delete-on-completion mode.

Full Changelog: thollander/actions-comment-pull-request@v2...v3.0.0

Commits
  • 24bffb9 Merge pull request #410 from thollander/chore/release-3.0.1
  • 5fd7012 chore: release 3.0.1
  • a38b001 Merge pull request #409 from thollander/fix/wrong-var-renaming
  • a11fbfe fix: some wrong variables renaming
  • cb13519 Merge pull request #300 from thollander/dependabot/npm_and_yarn/actions/githu...
  • 38af97b chore(deps): bump @​actions/github from 5.1.1 to 6.0.0
  • 301a80e Merge pull request #393 from thollander/dependabot/npm_and_yarn/prettier-3.3.3
  • 64dcac7 chore(deps-dev): bump prettier from 3.2.5 to 3.3.3
  • 0a327d5 Merge pull request #394 from thollander/dependabot/npm_and_yarn/actions/core-...
  • ece12ba Merge pull request #392 from thollander/dependabot/npm_and_yarn/vercel/ncc-0....
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 1, 2024
@inkydragon
Copy link
Member

@dependabot rebase

Bumps [thollander/actions-comment-pull-request](https://github.com/thollander/actions-comment-pull-request) from 2.5.0 to 3.0.1.
- [Release notes](https://github.com/thollander/actions-comment-pull-request/releases)
- [Commits](thollander/actions-comment-pull-request@fabd468...24bffb9)

---
updated-dependencies:
- dependency-name: thollander/actions-comment-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/github_actions/thollander/actions-comment-pull-request-3.0.1 branch from 4fb8119 to aa7f3fa Compare December 18, 2024 02:32
@inkydragon
Copy link
Member

I'm assuming that the pr launched by dependabot doesn't have permission to read a specific environment variable.

- name: Install SSH Client
if: github.event_name != 'pull_request' || github.repository == github.event.pull_request.head.repo.full_name # if this build is NOT a PR build, OR if this build is a PR build and the PR is NOT from a fork
uses: webfactory/ssh-agent@v0.9.0
with:
ssh-private-key: ${{ secrets.DEPLOY_KEY }}

@ViralBShah
Copy link
Member

What permissions need updating?

Copy link
Member

@LilithHafner LilithHafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed the diff from fabd468d3a1a0b97feee5f6b9e499eab0dd903f6 to 24bffb9b452ba05a4f3f77933840a6a841d1b32b but this PR LGTM assuming we can trust the changelog and upstream development.

@ViralBShah ViralBShah merged commit f8688bd into main Jan 7, 2025
2 checks passed
@ViralBShah ViralBShah deleted the dependabot/github_actions/thollander/actions-comment-pull-request-3.0.1 branch January 7, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants