Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path in test for deps.jl #22

Merged
merged 2 commits into from
Jul 11, 2018
Merged

Fix path in test for deps.jl #22

merged 2 commits into from
Jul 11, 2018

Conversation

andreasnoack
Copy link
Member

So "../deps/deps.jl", of course, has a different meaning depending on whether it is used in include or isfile. However, the tests are run from within the test directory so this wasn't caught by CI.

Fixed #21.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 43

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 94.091%

Files with Coverage Reduction New Missed Lines %
src/Arpack.jl 3 98.96%
Totals Coverage Status
Change from base Build 40: -0.1%
Covered Lines: 207
Relevant Lines: 220

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 11, 2018

Pull Request Test Coverage Report for Build 45

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.196%

Totals Coverage Status
Change from base Build 40: 0.0%
Covered Lines: 211
Relevant Lines: 224

💛 - Coveralls

@codecov-io
Copy link

codecov-io commented Jul 11, 2018

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files           2        2           
  Lines         225      225           
=======================================
  Hits          214      214           
  Misses         11       11
Impacted Files Coverage Δ
src/Arpack.jl 97.14% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4294759...728cccf. Read the comment docs.

@andreasnoack andreasnoack merged commit 2549905 into master Jul 11, 2018
@andreasnoack andreasnoack deleted the an/fixpath branch July 11, 2018 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants