Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back 5-arg mul! to lsmr #206

Open
haampie opened this issue Jul 9, 2018 · 4 comments
Open

Bring back 5-arg mul! to lsmr #206

haampie opened this issue Jul 9, 2018 · 4 comments

Comments

@haampie
Copy link
Member

haampie commented Jul 9, 2018

In #205 I have temporarily removed the 5-argument mul!(y, A, x, a, b) calls from lsmr, since there is no implementation for dense A. It worked becauselsmr implemented it itself, but I guess nobody wants IterativeSolvers.jl to extend LinearAlgebra.mul!.

Let's wait till we have the 5-argument mul! in LinearAlgebra and bring it back to lsmr only then.
@lostella
Copy link
Contributor

lostella commented Apr 5, 2019

Not sure this is ever coming back. We may want to consider using LinearAlgebra.BLAS.gemv! instead.

@andreasnoack
Copy link
Member

Please avoid calling the BLAS wrappers directly if possible. It would be better to call a generic version.

@dkarrasch dkarrasch mentioned this issue Jun 17, 2019
Open
@chriscoey
Copy link

it is endlessly frustrating that we don't have an efficient generic in-place 5 argument mul! in Julia

@chriscoey
Copy link

JuliaLang/julia#29634 has been merged (huzzah!)
hence we can now use 5-arg mul!

@chriscoey chriscoey mentioned this issue Aug 15, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@haampie @lostella @andreasnoack @chriscoey