Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use LinearAlgebra's new generic in-place 5-arg mul! wherever possible (requires Julia 1.3) #254

Open
chriscoey opened this issue Aug 15, 2019 · 3 comments

Comments

@chriscoey
Copy link

see JuliaLang/julia#29634

this will fix #206, #245 and is relevant to #251, #248

@davidschlegel
Copy link

I think this will also fix #295 .

@ranocha
Copy link
Member

ranocha commented Apr 30, 2021

I think #295 will also require updates of lines like

# Large vectors.
r_shadow = rand(T, n)
rs = Matrix{T}(undef, n, l + 1)
us = zeros(T, n, l + 1)

@davidschlegel
Copy link

davidschlegel commented Apr 30, 2021

Yes, and probably at some other lines. I am not familiar with the code, so I think I cannot really help here, but I would love to have this fixed. The cg function already has the functionality to work with CUDA types, and so I think it should be possible to do it here are well. #295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants