Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU friendly BLAS calls #251

Open
shashi opened this issue Jul 11, 2019 · 4 comments
Open

GPU friendly BLAS calls #251

shashi opened this issue Jul 11, 2019 · 4 comments

Comments

@shashi
Copy link

shashi commented Jul 11, 2019

@ChrisRackauckas found out that using CuArrays fails at points like https://github.com/JuliaMath/IterativeSolvers.jl/blob/17ef2613dff1d80724886797160ee01bd1bd2c71/src/simple.jl#L38

where the call to BLAS.axpy! explicitly assumes that the inputs are OK with OpenBLAS. The right alternative would be to use LinearAlgebra.axpy! (which as it turns out is a different function) and let it naturally dispatch to BLAS iff possible.

@pkofod
Copy link

pkofod commented Jul 25, 2019

see also #245 (I actually believe this is a duplicate of that)

@simonbyrne
Copy link

@pkofod
Copy link

pkofod commented Jul 31, 2019

Since I need this, I might be able to go over some of these. If anyone has a usecase/ something that doens't currently work, please post it so I can take it into account.

@simonbyrne
Copy link

We have some of our own code implemented:
https://github.com/climate-machine/CLIMA/tree/master/src/LinearSolvers
feel free to take/adapt what you need.

See also this comment for our needs: CliMA/ClimateMachine.jl#330 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants