Update to Julia 0.7 #198
Closed
Update to Julia 0.7 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostella
commented
Apr 20, 2018
| @@ -24,7 +25,7 @@ srand(1234321) | |||
|
|
|||
| b = rand(T, n) | |||
| x0 = rand(T, n) | |||
| tol = √eps(real(T)) | |||
| tol = 10*√eps(real(T)) | |||
There was a problem hiding this comment.
For example: here I had to increase this tolerance because otherwise a test fails. Not sure what causes this regression.
|
Will this receive some love any time soon? |
|
Just a few comments: I still seem to see a few |
|
Closing in favour of #205 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there's little discussion on updating IterativeSolvers to Julia 0.7: since I started updating some packages depending on IterativeSolvers as well, I thought of giving it a shot.
For now it looks like errors are gone, but there's still quite a few warnings to get rid of. Will keep working on this, I'm opening the PR to start getting feedback in case something is not right or could be done better.