Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quality assurance tests, fix ambiguity #135

Merged
merged 6 commits into from
Feb 24, 2021
Merged

Conversation

dkarrasch
Copy link
Member

This adds Aqua.jl to the test dependencies. It tests for, among others, method ambiguities, which I'm fixing here.

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #135 (5d4bab3) into master (a87d647) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files          14       14           
  Lines         919      921    +2     
=======================================
+ Hits          914      916    +2     
  Misses          5        5           
Impacted Files Coverage Δ
src/LinearMaps.jl 97.36% <ø> (ø)
src/composition.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a87d647...5d4bab3. Read the comment docs.

@dkarrasch dkarrasch merged commit f49e91b into master Feb 24, 2021
@dkarrasch dkarrasch deleted the dk/aquatesting branch February 24, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant