Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests with reference BLAS and LAPACK #128

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

amontoison
Copy link
Contributor

@amontoison amontoison commented Jun 9, 2024

I have the following tests that are not working:

@testset "Vanilla ReferenceBLAS_jll (ILP64)" begin
    run_all_tests("blas", reverse(ReferenceBLAS_jll.LIBPATH_list), :ILP64, "", tests = [dgemm, sdot])
end

@testset "LBT -> ReferenceBLAS_jll / LAPACK_jll (ILP64)" begin
    libdirs = unique(vcat(lbt_dir, ReferenceBLAS_jll.LIBPATH_list..., LAPACK_jll.LIBPATH_list..., CompilerSupportLibraries_jll.LIBPATH_list...))
    run_all_tests(blastrampoline_link_name(), libdirs, :ILP64, string(ReferenceBLAS_jll.libblas_path, ";", LAPACK_jll.liblapack_path); tests = [dgemm, dpstrf, sgesv, sdot])
end

I commented them.

I suspect that it's because they are already installed.
We should maybe modify the name and soname of the ILP64 libraries of ReferenceBLAS_jll.jl and LAPACK_jll.jl :
libblas.so and liblapack.so -> libblas64.so and liblapack64.so.

@amontoison amontoison requested a review from staticfloat June 9, 2024 02:24
test/runtests.jl Outdated
@@ -159,7 +159,7 @@ end
# end

# Test against MKL_jll using `libmkl_rt`, which is :LP64 by default
if MKL_jll.is_available()
if MKL_jll.is_available() && !Sys.iswindows()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you limiting this to non-windows?

Copy link
Contributor Author

@amontoison amontoison Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got an issue with rights ln ibmkl_rt.dll but it seems to be fixed with the latest JLL (2024.2.0).

I still the issue here with buildkit :(

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that was the first MKL release where all our known issues got sorted out.

test/runtests.jl Outdated
@@ -128,9 +128,9 @@ end
run_all_tests("blas32", reverse(ReferenceBLAS32_jll.LIBPATH_list), :LP64, "", tests = [dgemm, sdot])
end

@testset "Vanilla ReferenceBLAS_jll (ILP64)" begin
run_all_tests("blas", reverse(ReferenceBLAS_jll.LIBPATH_list), :ILP64, "", tests = [dgemm, sdot])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the error that you were seeing here? Looking through the CI logs, I don't understand.

@ViralBShah
Copy link
Collaborator

We should try to get this one merged.

test/runtests.jl Outdated Show resolved Hide resolved
@staticfloat staticfloat force-pushed the reference-blas-lapack branch from de61b4d to cccdca2 Compare July 31, 2024 16:43
@staticfloat
Copy link
Member

The failure on armv7l is silly; it's because we use Julia v1.7 (the last released version on armv7l) but LAPACK32_jll says it needs Julia v1.9+, presumably because it relies on some newer libblastrampoline versions.

The failures on windows look real however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants