Supress logging within writeproto to prevent infinite recursion.
#100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipVinc
reviewed
May 15, 2021
|
CI is not running even if I approved it. |
|
Thanks for the review and merging @PhilipVinc. Glad to get it sorted. |
|
Thanks to you, actually. Anyhow, I wanted to tag a new release, but It seems to me that the test you added is a bit flaky (not more than GitHub Actions have been those last few days, though). |
|
I don't understand at a glance how this can fail somewhere and pass somewhere else... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #96, following the suggestion of @oxinabox.