Fix bug for tags that end in non-ascii chars #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you add a test for the behaviour that is fixed? |
|
ehhh not really atm sorry no time. You can not merge if you want until some future time that I may find to provide one, but that day may never come 😬 Thanks for the package! |
|
Or you can get crazy and take a chance and merge 😄 |
|
Forgot to mention the scenario this fixes: tblogging with e.g. the tag "μff" then using TensorBoardLogger.map_summaries throws an error without this. Minimal trigger using TensorBoardLogger: tags_match_re_im
tags_match_re_im("μff", "new_tag")Thanks! 🙏 (edited to show clearer example) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.