Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load Requires.jl only if needed #180

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

avik-pal
Copy link
Contributor

Previous

julia> @time_imports using LossFunctions
               ┌ 0.0 ms Requires.__init__() 
    173.5 ms  Requires 99.67% compilation time
      4.0 ms  LossFunctions

Current

julia> @time_imports using LossFunctions
      3.5 ms  LossFunctions

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.85%. Comparing base (cc0f67d) to head (46d65d4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   95.84%   95.85%   +0.01%     
==========================================
  Files          10       10              
  Lines         529      531       +2     
==========================================
+ Hits          507      509       +2     
  Misses         22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliohm juliohm merged commit 8be7671 into JuliaML:master Aug 26, 2024
7 checks passed
@avik-pal avik-pal deleted the ap/requires branch August 27, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants