-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move streaming to StreamCallbacks.jl #65
Comments
Bump here. Is there any interest in refactoring the functionality with a new dep? The current implementation is not correct and will lead to more errors. |
I would say it's probably better to separate them out -- I'd be happy to see StreamingCallbacks.jl implemented here. As to this point:
Not a concern on my end, if anything that strikes me as pretty ergonomic. |
If the current implementation is not correct and will lead to errors, I say full steam ahead. |
- Add StreamCallbacks.jl as a dependency - Update request_body_live to use StreamCallbacks.jl - Add support for custom stream parsing and sinks - Update documentation with comprehensive streaming examples - Maintain backward compatibility with existing streamcallback usage Resolves JuliaML#65
I would like to propose moving streaming functionality to a separate package (made by me): https://github.com/svilupp/StreamCallbacks.jl
Why?
Downsides
I've been using it in PromptingTools.jl for a few releases already and it seems to work well.
The text was updated successfully, but these errors were encountered: