Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradients in ManifoldDiff? #13

Closed
kellertuer opened this issue Feb 8, 2023 · 4 comments
Closed

Gradients in ManifoldDiff? #13

kellertuer opened this issue Feb 8, 2023 · 4 comments

Comments

@kellertuer
Copy link
Member

When writing the first example in ManoptExamples.jl,
I noticed that grad_distance was still defined in Manopt.jl. I want to move those gradients out - for sure.
Sure, gradient conversion (in Manifold.jl) should stay there since those functions are very manifold-specific.

But besides in the examples, they could also be placed here? We could also collect other simple gradients, though I do not have many in mind for now.

@mateuszbaran
Copy link
Member

I didn't really need grad_distance for anything so I didn't move it. It is very simple so I'm not even sure how useful it is but if you want put it in ManifoldDiff then it's also fine 🙂 .

@kellertuer
Copy link
Member Author

We could also keep it in the ManopExample package, I am open to both.

@mateuszbaran
Copy link
Member

Feel free to put it in the package you prefer 🙂

@kellertuer
Copy link
Member Author

I think it would also fit here well, I will move it then the next days.

kellertuer added a commit that referenced this issue Feb 11, 2023
* resolve #13
* resolve #14
* rework docs and their dependencies.
* bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants