-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradients in ManifoldDiff? #13
Comments
I didn't really need |
We could also keep it in the ManopExample package, I am open to both. |
Feel free to put it in the package you prefer 🙂 |
I think it would also fit here well, I will move it then the next days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When writing the first example in ManoptExamples.jl,
I noticed that
grad_distance
was still defined inManopt.jl
. I want to move those gradients out - for sure.Sure, gradient conversion (in Manifold.jl) should stay there since those functions are very manifold-specific.
But besides in the examples, they could also be placed here? We could also collect other simple gradients, though I do not have many in mind for now.
The text was updated successfully, but these errors were encountered: