Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Manifolds.jl extension to Manifolds.jl #21

Merged
merged 3 commits into from
Jun 3, 2023
Merged

Move Manifolds.jl extension to Manifolds.jl #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c94fce5
Move Manifolds.jl extension to Manifolds.jl
mateuszbaran Jun 3, 2023
ef5d985
Fix for Julia < 1.9
mateuszbaran Jun 3, 2023
b646928
bump version
mateuszbaran Jun 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "ManifoldDiff"
uuid = "af67fdf4-a580-4b9f-bbec-742ef357defd"
authors = ["Seth Axen <seth.axen@gmail.com>", "Mateusz Baran <mateuszbaran89@gmail.com>", "Ronny Bergmann <manopt@ronnybergmann.net>"]
version = "0.3.2"
version = "0.3.3"

[deps]
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
Expand All @@ -13,15 +13,13 @@ Requires = "ae029012-a4dd-5104-9daa-d747884805df"
FiniteDiff = "6a86dc24-6348-571c-b903-95158fe2bd41"
FiniteDifferences = "26cc04aa-876d-5657-8c51-4c34ba976000"
ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
Manifolds = "1cead3c2-87b3-11e9-0ccd-23c62b72b94e"
ReverseDiff = "37e2e3b7-166d-5795-8a7a-e32c996b4267"
Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"

[extensions]
ManifoldDiffFiniteDiffExt = "FiniteDiff"
ManifoldDiffFiniteDifferencesExt = "FiniteDifferences"
ManifoldDiffForwardDiffExt = "ForwardDiff"
ManifoldDiffManifoldsExt = "Manifolds"
ManifoldDiffReverseDiffExt = "ReverseDiff"
ManifoldDiffZygoteExt = "Zygote"

Expand Down
168 changes: 0 additions & 168 deletions ext/ManifoldDiffManifoldsExt.jl
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions src/ManifoldDiff.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,10 +190,6 @@ function __init__()
include("../ext/ManifoldDiffForwardDiffExt.jl")
end

@require Manifolds = "1cead3c2-87b3-11e9-0ccd-23c62b72b94e" begin
include("../ext/ManifoldDiffManifoldsExt.jl")
end

@require ReverseDiff = "37e2e3b7-166d-5795-8a7a-e32c996b4267" begin
include("../ext/ManifoldDiffReverseDiffExt.jl")
end
Expand Down
26 changes: 1 addition & 25 deletions test/manifold_specializations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ using Test
using LinearAlgebra

using ManifoldDiff:
differential_exp_argument,
differential_exp_argument_lie_approx,
differential_inverse_retract_argument_fd_approx
differential_exp_argument, differential_inverse_retract_argument_fd_approx

@testset "Rotations(3)" begin
M = Rotations(3)
Expand All @@ -24,28 +22,6 @@ using ManifoldDiff:
ω = [[1.0, 2.0, 3.0], [3.0, 2.0, 1.0], [1.0, 3.0, 2.0]]
pts = [exp(M, p, hat(M, p, ωi)) for ωi in ω]
Xpts = [hat(M, p, [-1.0, 2.0, 0.5]), hat(M, p, [1.0, 0.0, 0.5])]

@testset "differentials" begin
q2 = exp(G, pts[1], Xpts[2])
@test isapprox(
G,
q2,
differential_exp_argument_lie_approx(G, pts[1], Xpts[1], Xpts[2]; n = 0),
Xpts[2],
)
diff_ref = [
0.0 -0.7482721017619345 -0.508151233069837
0.7482721017619345 0.0 -0.10783358474129323
0.508151233069837 0.10783358474129323 0.0
]
@test isapprox(
G,
q2,
differential_exp_argument_lie_approx(G, pts[1], Xpts[1], Xpts[2]),
diff_ref;
atol = 1e-12,
)
end
end

@testset "FiniteDifferenceLogDiffArgumentMethod" begin
Expand Down